[ https://issues.apache.org/jira/browse/GOBBLIN-827?focusedWorklogId=279245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279245 ]
ASF GitHub Bot logged work on GOBBLIN-827: ------------------------------------------ Author: ASF GitHub Bot Created on: 18/Jul/19 19:00 Start Date: 18/Jul/19 19:00 Worklog Time Spent: 10m Work Description: htran1 commented on pull request #2688: [GOBBLIN-827] Add more events URL: https://github.com/apache/incubator-gobblin/pull/2688#discussion_r305069336 ########## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/EntityMissingEventBuilder.java ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.metrics.event; + +import java.util.Map; + +import org.apache.commons.lang.StringUtils; + +import lombok.Getter; + +import org.apache.gobblin.metrics.GobblinTrackingEvent; + + +/** + * An event reporting missing any kind of entity, e.g. WorkUnit, Record, kafka topic + */ +public class EntityMissingEventBuilder extends GobblinEventBuilder { Review comment: Builder is a confusing name here since the object is directly used to host the values and not just for building the event. There is a `fromEvent`. Instead of `build`, maybe `toEvent` makes more sense. This can be considered in a future refactoring. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 279245) Time Spent: 50m (was: 40m) > Add more events > --------------- > > Key: GOBBLIN-827 > URL: https://issues.apache.org/jira/browse/GOBBLIN-827 > Project: Apache Gobblin > Issue Type: Task > Reporter: Zhixiong Chen > Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Add the following events > - `JobStateEventBuilder` to report gobblin job state or MR job state > - `EntityMissingEventBuilder` to report a missing instance of a certain entity -- This message was sent by Atlassian JIRA (v7.6.14#76016)