[
https://issues.apache.org/jira/browse/GOBBLIN-817?focusedWorklogId=281186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-281186
]
ASF GitHub Bot logged work on GOBBLIN-817:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/19 17:35
Start Date: 23/Jul/19 17:35
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2681: GOBBLIN-817:
Implement a workaround for Helix Workflow being stuck in…
URL:
https://github.com/apache/incubator-gobblin/pull/2681#issuecomment-514309719
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=h1)
Report
> Merging
[#2681](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/bee393352880aad5d9edb05fcc2e5f5f4e5f4811?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `61.11%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2681 +/- ##
============================================
- Coverage 44.8% 44.79% -0.01%
+ Complexity 8686 8685 -1
============================================
Files 1878 1878
Lines 70045 70060 +15
Branches 7701 7702 +1
============================================
+ Hits 31382 31384 +2
- Misses 35759 35771 +12
- Partials 2904 2905 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...er/GobblinHelixDistributeJobExecutionLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4RGlzdHJpYnV0ZUpvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=)
| `57.93% <100%> (+1.02%)` | `10 <0> (ø)` | :arrow_down: |
|
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
| `81.53% <100%> (+0.28%)` | `26 <0> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.71% <30%> (-9.13%)` | `11 <0> (-2)` | |
|
[...org/apache/gobblin/publisher/DataPublisherKey.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9EYXRhUHVibGlzaGVyS2V5LmphdmE=)
| `53.33% <0%> (-13.34%)` | `5% <0%> (-1%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `65.72% <0%> (+0.93%)` | `29% <0%> (ø)` | :arrow_down: |
|
[.../limiter/RedirectAwareRestClientRequestSender.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9SZWRpcmVjdEF3YXJlUmVzdENsaWVudFJlcXVlc3RTZW5kZXIuamF2YQ==)
| `87.2% <0%> (+2.32%)` | `18% <0%> (+1%)` | :arrow_up: |
| ... and [2
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2681/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=footer).
Last update
[bee3933...5103293](https://codecov.io/gh/apache/incubator-gobblin/pull/2681?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 281186)
Time Spent: 20m (was: 10m)
> Implement a workaround for Helix Workflow being stuck in STOPPING state
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-817
> URL: https://issues.apache.org/jira/browse/GOBBLIN-817
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Helix task cancellation can cause a workflow to be indefinitely stuck in the
> STOPPING state, if any of the tasks in the workflow ignores the cancel
> request. The Helix bug is tracked in
> [HELIX-1933|https://jira01.corp.linkedin.com:8443/browse/HELIX-1933]. This
> temporary workaround deletes the Helix workflow after a predefined time
> interval in the STOPPING state.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
