arjun4084346 edited a comment on issue #2700: [GOBBLIN-839] Catch all 
exceptions when getting flow template at runtime
URL: 
https://github.com/apache/incubator-gobblin/pull/2700#issuecomment-519341125
 
 
   I would rather catch all the exceptions than catching a broader `Exception` 
to detect any new unforeseen issue. e.g. if in future new code changes in 
getFlowTemplate() throws some new exception. LGTM otherwise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to