autumnust commented on a change in pull request #2701: GOBBLIN-846: Enhance LogCopier service to handle continuous YARN log … URL: https://github.com/apache/incubator-gobblin/pull/2701#discussion_r312147542
########## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java ########## @@ -143,8 +144,9 @@ protected final FileSystem fs; private final List<Service> services = Lists.newArrayList(); - private final String applicationName; - private final String applicationId; + protected final String applicationName; + protected final String applicationId; + protected final Optional<ContainerId> containerId; Review comment: Are we spilling implementation details (e.g. yarn for here) into a generic-purpose class (`GobblinTaskRunner`) by doing this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
