[
https://issues.apache.org/jira/browse/GOBBLIN-846?focusedWorklogId=291562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291562
]
ASF GitHub Bot logged work on GOBBLIN-846:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/19 20:32
Start Date: 08/Aug/19 20:32
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2701: GOBBLIN-846:
Enhance LogCopier service to handle continuous YARN log …
URL: https://github.com/apache/incubator-gobblin/pull/2701#discussion_r312229990
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/logs/LogCopier.java
##########
@@ -178,53 +188,91 @@ protected Scheduler scheduler() {
return Scheduler.newFixedRateSchedule(0,
this.sourceLogFileMonitorInterval, this.timeUnit);
}
+ private boolean shouldIncludeLogFile(FileStatus logFile) {
Review comment:
This should be fine, since only the LogCopier thread will prune
copiedFileNames while LogCopyTask will add copiedFileNames. The main LogCopier
thread blocks until LogCopyTasks finish and then deletes files from the
copiedFileNames.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 291562)
Time Spent: 40m (was: 0.5h)
> Enhance LogCopier service to handle continuous YARN log aggregation
> -------------------------------------------------------------------
>
> Key: GOBBLIN-846
> URL: https://issues.apache.org/jira/browse/GOBBLIN-846
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-yarn
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This task enhances LogCopier service to perform continuous log aggregation
> for long-running Gobblin-on-Yarn applications. It periodically copies rolled
> container logs to a specified location on HDFS. The "current" log file is
> copied in the end as part of the service shutdown sequence.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
