[
https://issues.apache.org/jira/browse/GOBBLIN-848?focusedWorklogId=292143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292143
]
ASF GitHub Bot logged work on GOBBLIN-848:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 16:33
Start Date: 09/Aug/19 16:33
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2703:
[GOBBLIN-848] Make initialization of CompactionSource extensible with certain
protection
URL: https://github.com/apache/incubator-gobblin/pull/2703
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA]
- https://issues.apache.org/jira/browse/GOBBLIN-848
### Description
- `getSourceFileSystem` is removed to use `HadoopUtils.getSourceFileSystem`
instead.
- Adding two methods to group init methods together and leave an extensible
method to derived class to implement its own customized init logic, while not
allowing it to skip any compulsory init steps in `CompactionSource`.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 292143)
Time Spent: 10m
Remaining Estimate: 0h
> Make initialization of CompactionSource extensible
> ---------------------------------------------------
>
> Key: GOBBLIN-848
> URL: https://issues.apache.org/jira/browse/GOBBLIN-848
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
