[
https://issues.apache.org/jira/browse/GOBBLIN-849?focusedWorklogId=292309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292309
]
ASF GitHub Bot logged work on GOBBLIN-849:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 22:30
Start Date: 09/Aug/19 22:30
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2705: [GOBBLIN-849]
Connection to Oracle using service name and update meta…
URL:
https://github.com/apache/incubator-gobblin/pull/2705#issuecomment-520084380
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=h1)
Report
> Merging
[#2705](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/8903ebf3807af3369839069e2082afa70c7fe77e?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2705 +/- ##
============================================
- Coverage 44.9% 44.88% -0.02%
+ Complexity 8713 8709 -4
============================================
Files 1879 1879
Lines 70079 70083 +4
Branches 7703 7706 +3
============================================
- Hits 31466 31454 -12
- Misses 35702 35719 +17
+ Partials 2911 2910 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...rg/apache/gobblin/source/jdbc/OracleExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL09yYWNsZUV4dHJhY3Rvci5qYXZh)
| `43.83% <0%> (-1.24%)` | `7 <0> (ø)` | |
|
[...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh)
| `70% <0%> (-30%)` | `3% <0%> (-2%)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
|
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
| `60.41% <0%> (-3.48%)` | `9% <0%> (ø)` | |
|
[...ache/gobblin/couchbase/writer/CouchbaseWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyLmphdmE=)
| `66.27% <0%> (-2.33%)` | `11% <0%> (ø)` | |
|
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
| `81.25% <0%> (-2.09%)` | `26% <0%> (-2%)` | |
|
[...ache/gobblin/cluster/GobblinHelixJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iU2NoZWR1bGVyLmphdmE=)
| `39.21% <0%> (-1.31%)` | `6% <0%> (ø)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `41.83% <0%> (ø)` | `13% <0%> (-1%)` | :arrow_down: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `66.19% <0%> (+0.46%)` | `29% <0%> (ø)` | :arrow_down: |
| ... and [2
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=footer).
Last update
[8903ebf...486307c](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 292309)
Time Spent: 20m (was: 10m)
> Connection to Oracle using service name and update metadata query for
> OracleExtractor
> -------------------------------------------------------------------------------------
>
> Key: GOBBLIN-849
> URL: https://issues.apache.org/jira/browse/GOBBLIN-849
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Siddhesh Sudesh Narvekar
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This issue has an improvement and solves a bug.
> Improvement: Enable OracleExtractor to connect to Oracle using service name.
> Bug: METADATA_SCHEMA_PSTMT_FORMAT query updated to consider owner and table
> name in upper case.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
