arjun4084346 commented on a change in pull request #2702: [GOBBLIN-847] Flow
level sla
URL: https://github.com/apache/incubator-gobblin/pull/2702#discussion_r312670872
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -473,22 +474,20 @@ private void initialize(Dag<JobExecutionPlan> dag)
/**
* Proceed the execution of each dag node based on job status.
*/
- private void pollAndAdvanceDag()
- throws IOException {
+ private void pollAndAdvanceDag() throws IOException, ExecutionException,
InterruptedException {
this.failedDagIdsFinishRunning.clear();
-
Map<String, Set<DagNode<JobExecutionPlan>>> nextSubmitted =
Maps.newHashMap();
List<DagNode<JobExecutionPlan>> nodesToCleanUp = Lists.newArrayList();
+
for (DagNode<JobExecutionPlan> node: this.jobToDag.keySet()) {
- long pollStartTime = System.nanoTime();
+ boolean slaKilled = slaKillIfNeeded(node);
+
JobStatus jobStatus = pollJobStatus(node);
- Instrumented.updateTimer(this.jobStatusPolledTimer, System.nanoTime()
- pollStartTime, TimeUnit.NANOSECONDS);
Review comment:
Moved it inside the method pollJobStatus(). I think that would give a more
accurate measurement of the poll time; and will also make this method
pollAndAdvanceDag() cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
