autumnust commented on a change in pull request #2719: [GOBBLIN-863]Handle race
condition issue for hive registration
URL: https://github.com/apache/incubator-gobblin/pull/2719#discussion_r318253087
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveLock.java
##########
@@ -37,30 +39,45 @@
* </p>
*/
public class HiveLock {
+ private static String HIVE_LOCK_TYPE =
HiveMetaStoreBasedRegister.HIVE_REGISTER_METRICS_PREFIX + "lock.type";
+ private static String HIVE_LOCK_TYPE_DEFAULT =
"org.apache.gobblin.hive.HiveLockFactory";
- private static final Joiner JOINER = Joiner.on(' ').skipNulls();
+ private Properties properties;
- private final Striped<Lock> locks = Striped.lazyWeakLock(Integer.MAX_VALUE);
+ private static final Joiner JOINER = Joiner.on('/').skipNulls();
Review comment:
using `.` seems more intuitive when it comes to the relation between db and
table. But I don't have strong option on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
