[
https://issues.apache.org/jira/browse/GOBBLIN-875?focusedWorklogId=309320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309320
]
ASF GitHub Bot logged work on GOBBLIN-875:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 22:31
Start Date: 09/Sep/19 22:31
Worklog Time Spent: 10m
Work Description: shirshanka commented on pull request #2729:
GOBBLIN-875: Emit container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322477750
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
##########
@@ -196,6 +196,11 @@ public GobblinTaskRunner(String applicationName,
this.services.addAll(suite.getServices());
this.services.addAll(getServices());
+
+ if (ConfigUtils.getBoolean(this.config,
GobblinClusterConfigurationKeys.CONTAINER_HEALTH_METRICS_SERVICE_ENABLED,
false)) {
Review comment:
Create a single static constant for the default value for this config, so
you don't have to say false in two places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 309320)
Time Spent: 50m (was: 40m)
> Emit container health metrics when running in cluster mode
> ----------------------------------------------------------
>
> Key: GOBBLIN-875
> URL: https://issues.apache.org/jira/browse/GOBBLIN-875
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This task implements a service that emits CPU/Memory health metrics from the
> JVM when running in the cluster mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
