[
https://issues.apache.org/jira/browse/GOBBLIN-896?focusedWorklogId=323792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323792
]
ASF GitHub Bot logged work on GOBBLIN-896:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 23:16
Start Date: 04/Oct/19 23:16
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2750: [GOBBLIN-896]
Clone schema and field props in AvroSchemaFieldRemover
URL:
https://github.com/apache/incubator-gobblin/pull/2750#issuecomment-538588874
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=h1)
Report
> Merging
[#2750](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/5b8af8cf6e932e8031ef060c79260a4a8f47974c?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2750 +/- ##
============================================
+ Coverage 45.27% 45.28% +<.01%
- Complexity 8828 8832 +4
============================================
Files 1889 1889
Lines 70634 70640 +6
Branches 7757 7759 +2
============================================
+ Hits 31979 31986 +7
Misses 35701 35701
+ Partials 2954 2953 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=)
| `94.82% <100%> (+0.59%)` | `27 <0> (+2)` | :arrow_up: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.87% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=footer).
Last update
[5b8af8c...1a5661d](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323792)
Time Spent: 0.5h (was: 20m)
> Clone schema or field props in AvroFieldRemover
> -----------------------------------------------
>
> Key: GOBBLIN-896
> URL: https://issues.apache.org/jira/browse/GOBBLIN-896
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, `AvroFieldRemover` ignores schema and field level properties while
> cloning the schema and its fields. The change is to fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
