[
https://issues.apache.org/jira/browse/GOBBLIN-912?focusedWorklogId=329490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329490
]
ASF GitHub Bot logged work on GOBBLIN-912:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/19 23:48
Start Date: 16/Oct/19 23:48
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2766:
[GOBBLIN-912]Enable TTL caching on Hive Metastore client connection
URL: https://github.com/apache/incubator-gobblin/pull/2766#discussion_r335757613
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveMetastoreClientPool.java
##########
@@ -59,6 +60,17 @@
public static final String POOL_CACHE_TTL_MINUTES_KEY =
"hive.metaStorePoolCache.ttl";
+ public static final String POOL_EVICTION_POLICY_CLASS_NAME =
"org.apache.commons.pool2.impl.DefaultEvictionPolicy";
Review comment:
What is the behavior of this eviction policy? Can we add a javadoc to help
user understand why we are using this eviction policy? Also, should this be
configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 329490)
Time Spent: 0.5h (was: 20m)
> Enable TTL caching on Hive Metastore client connection
> ------------------------------------------------------
>
> Key: GOBBLIN-912
> URL: https://issues.apache.org/jira/browse/GOBBLIN-912
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
