[
https://issues.apache.org/jira/browse/GOBBLIN-910?focusedWorklogId=330228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330228
]
ASF GitHub Bot logged work on GOBBLIN-910:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/19 02:06
Start Date: 18/Oct/19 02:06
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2765: [GOBBLIN-910]
Added a unix timestamp recursive copyable dataset finder
URL:
https://github.com/apache/incubator-gobblin/pull/2765#issuecomment-542454409
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=h1)
Report
> Merging
[#2765](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/b92f516a4e7a9b2c8bd2e90d71026fb07cb56da7?src=pr&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2765 +/- ##
============================================
+ Coverage 45.3% 45.33% +0.03%
- Complexity 8846 8858 +12
============================================
Files 1892 1894 +2
Lines 70752 70815 +63
Branches 7773 7784 +11
============================================
+ Hits 32054 32106 +52
- Misses 35740 35747 +7
- Partials 2958 2962 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ement/copy/UnixTimestampCopyableDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVW5peFRpbWVzdGFtcENvcHlhYmxlRGF0YXNldEZpbmRlci5qYXZh)
| `100% <100%> (ø)` | `2 <2> (?)` | |
|
[...nt/copy/UnixTimestampRecursiveCopyableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVW5peFRpbWVzdGFtcFJlY3Vyc2l2ZUNvcHlhYmxlRGF0YXNldC5qYXZh)
| `85% <85%> (ø)` | `8 <8> (?)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `100% <0%> (+7.14%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2765/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=footer).
Last update
[b92f516...cf51242](https://codecov.io/gh/apache/incubator-gobblin/pull/2765?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330228)
Time Spent: 1h 20m (was: 1h 10m)
> Add Unix timestamp copyable recursive dataset finder with snapshot selection
> policy
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> A dataset finder that takes a lookback time and a snapshot selection p[olicy
> to return a list of files to copy from source to destination.
> The finder also takes in a regex that is used to extract the timestamp from
> the path.
> snapshot policies
> ALL: Returns all files within the look back time
> EARLIEST: returns the earliest snapshot per day of the look back time
> LATEST: returns the last snapshot per day of the look back time
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
