[
https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=332133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332133
]
ASF GitHub Bot logged work on GOBBLIN-895:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/19 18:20
Start Date: 22/Oct/19 18:20
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2751:
[GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide
is accurate
URL: https://github.com/apache/incubator-gobblin/pull/2751#discussion_r337676404
##########
File path: bin/gobblin.sh
##########
@@ -417,7 +427,15 @@ function start() {
CLASS_N_ARGS=''
if [[ "$GOBBLIN_MODE" = "$STANDALONE_MODE" ]]; then
CLASS_N_ARGS="$STANDALONE_CLASS $GOBBLIN_CONF/application.conf"
+ ADDITIONAL_ARGS="-Dgobblin.logs.dir=${GOBBLIN_LOGS}"
+
+ if [ -z "$GOBBLIN_WORK_DIR" ] && [ "$CHECK_ENV_VARS" == true
]; then
Review comment:
I originally removed the ENV variables deliberately to make one way of
controlling everything. but i can see ENV variable can be additional way of
configuring too. but should not be the only way. may be we can merge it or make
it overridable by user config for GOBBLIN_JOB_CONFIG_DIR and GOBBLIN_WORK_DIR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 332133)
Time Spent: 1h 10m (was: 1h)
> Gobblin Standalone Script does not run properly
> -----------------------------------------------
>
> Key: GOBBLIN-895
> URL: https://issues.apache.org/jira/browse/GOBBLIN-895
> Project: Apache Gobblin
> Issue Type: Bug
> Affects Versions: 0.15.0
> Reporter: William Lo
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Gobblin.sh's changes do not support Gobblin standalone properly as specified
> in the getting started docs. This is due to a regression in the
> configurations of the app and the logger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
