Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340796164
########## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ########## @@ -0,0 +1,110 @@ +# In the future, build the kubernetes cluster from the official docker account +# Also ensure that proper tagging/versioning is done i.e. remove :latest tag and instead use the digest of the container + +apiVersion: apps/v1 +kind: Deployment +metadata: + name: 'gaas-deployment' + labels: + app: gaas-deployment +spec: + selector: + matchLabels: + app: gaas + replicas: 1 + template: + metadata: + name: 'gaas' + labels: + app: gaas + spec: + volumes: + - name: shared-jobs + persistentVolumeClaim: + claimName: shared-jobs-claim + - name: shared-template-catalogs + persistentVolumeClaim: + claimName: shared-template-catalogs-claim + - name: gaas-config + configMap: + name: gaas-config + containers: + - name: gobblin-service + image: will97/gobblin-as-a-service:latest + command: ["./bin/entrypoint.sh"] + args: ["--args", "-DmysqlCredentials.user=$(MYSQL_USERNAME) -DmysqlCredentials.password=$(MYSQL_PASSWORD)"] + env: + - name: MYSQL_USERNAME + valueFrom: + secretKeyRef: + name: mysql-credentials + key: username + - name: MYSQL_PASSWORD + valueFrom: + secretKeyRef: + name: mysql-credentials + key: password + volumeMounts: + - name: shared-jobs + mountPath: /tmp/gobblin-as-service/jobs + - name: shared-template-catalogs Review comment: I'll remove `share-template-catalog`, I was hoping to use it to share default templates among pods but I determined a better way of doing that in a future PR using configMaps `gaas-config` is for the `.conf` file for GaaS, I use this to replace the one defined in the `conf` folder due a change in the configs to support MySQL ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
