Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate
usage of env variables in gobblin scripts and configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341287822
##########
File path: bin/gobblin-env.sh
##########
@@ -17,4 +17,6 @@
# limitations under the License.
#
-# Set Gobblin specific environment variables here.
+# export environment variables here to be used in gobblin.sh scripts and
gobblin platform configs.
+export GOBBLIN_WORK_DIR=$GOBBLIN_HOME/gobblin-work-dir
+export GOBBLIN_JOB_CONFIG_DIR=$GOBBLIN_HOME/gobblin-job-config-dir
Review comment:
I think to keep it more consistent with our old naming conventions we should
do
`GOBBLIN_WORK_DIR=$GOBBLIN_HOME/work`
`GOBBLIN_JOB_CONFIG_DIR=$GOBBLIN_HOME/jobs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
