autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance
DDL to add column and column.types with case-preserving schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341356298
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/converter/AbstractAvroToOrcConverter.java
##########
@@ -85,6 +86,7 @@
* Subdirectory within destination ORC table directory to publish data
*/
private static final String PUBLISHED_TABLE_SUBDIRECTORY = "final";
+ public static final String OUTPUT_AVRO_SCHEMA_KEY = "output.avro.schema";
Review comment:
Does it need to be public static ? Limit access modifiers so that it won't
be accidentally touched by irrelevant constructs in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
