[
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=337462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337462
]
ASF GitHub Bot logged work on GOBBLIN-940:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/19 18:32
Start Date: 01/Nov/19 18:32
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2789:
[GOBBLIN-940]Add synchronization on workunit persistency before Helix job
launching
URL: https://github.com/apache/incubator-gobblin/pull/2789#discussion_r341686549
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
##########
@@ -295,23 +295,34 @@ protected void executeCancellation() {
SerializationUtils.serializeState(this.fs, jobStateFilePath,
this.jobContext.getJobState());
}
- LOGGER.debug("GobblinHelixJobLauncher.createJob: jobStateFilePath {},
jobState {} jobProperties {}",
+ // Block on all persistency of workunits finished
+ // It is necessary when underlying storage being and Helix activate
task-execution before the workunit being persisted.
Review comment:
`storage being and`? Seems like something is missing here in this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 337462)
Time Spent: 40m (was: 0.5h)
> Synchronization between workunit persistency and Helix job launching
> --------------------------------------------------------------------
>
> Key: GOBBLIN-940
> URL: https://issues.apache.org/jira/browse/GOBBLIN-940
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
