autumnust commented on a change in pull request #2792: [GOBBLIN-933] add
support for array of unions in json schema
URL: https://github.com/apache/incubator-gobblin/pull/2792#discussion_r341800803
##########
File path: gobblin-core/src/test/resources/converter/jsonToAvroRecord.json
##########
@@ -1,4 +1,6 @@
-{"nullableField": null,
+{
+ "arrayFieldWithUnion": ["arrU1", "arrU2", "arrU3"],
Review comment:
+1
BTW we should try to stay aligned with Avro schema guide to always place
null in the first to indicate nullable schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
