[
https://issues.apache.org/jira/browse/GOBBLIN-945?focusedWorklogId=338961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338961
]
ASF GitHub Bot logged work on GOBBLIN-945:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 19:42
Start Date: 05/Nov/19 19:42
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2795: GOBBLIN-945:
Refactor Kafka extractor statistics tracking to allow co…
URL:
https://github.com/apache/incubator-gobblin/pull/2795#issuecomment-549956451
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=h1)
Report
> Merging
[#2795](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/94a508b38ec8bd879614f2d9bf0eeb96513ca7cf?src=pr&el=desc)
will **decrease** coverage by `0.84%`.
> The diff coverage is `40.58%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2795 +/- ##
============================================
- Coverage 45.32% 44.48% -0.85%
+ Complexity 8862 8714 -148
============================================
Files 1894 1895 +1
Lines 70910 70939 +29
Branches 7799 7799
============================================
- Hits 32141 31555 -586
- Misses 35803 36460 +657
+ Partials 2966 2924 -42
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...bblin/kafka/client/GobblinKafkaConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9Hb2JibGluS2Fma2FDb25zdW1lckNsaWVudC5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...ce/extractor/extract/kafka/KafkaAvroExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUF2cm9FeHRyYWN0b3IuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...he/gobblin/kafka/client/Kafka08ConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2EvY2xpZW50L0thZmthMDhDb25zdW1lckNsaWVudC5qYXZh)
| `55.69% <0%> (-0.36%)` | `22 <0> (ø)` | |
|
[...source/extractor/extract/kafka/KafkaExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3Rvci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...he/gobblin/kafka/client/Kafka09ConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2EvY2xpZW50L0thZmthMDlDb25zdW1lckNsaWVudC5qYXZh)
| `75.71% <0%> (-1.1%)` | `8 <0> (ø)` | |
|
[...ctor/extract/kafka/KafkaExtractorStatsTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3RvclN0YXRzVHJhY2tlci5qYXZh)
| `47.36% <47.36%> (ø)` | `19 <19> (?)` | |
|
[...source/extractor/extract/kafka/KafkaPartition.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVBhcnRpdGlvbi5qYXZh)
| `44.64% <85.71%> (+44.64%)` | `3 <2> (+3)` | :arrow_up: |
|
[...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
|
[...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
| ... and [49
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=footer).
Last update
[94a508b...efdb493](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 338961)
Time Spent: 40m (was: 0.5h)
> Refactor Kafka extractor statistics tracking to allow code reuse across both
> batch and streaming execution modes
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-945
> URL: https://issues.apache.org/jira/browse/GOBBLIN-945
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Current implementation of kafka extractor stats tracking is deeply integrated
> with the batch implementation of KafkaExtractor preventing it from being used
> in streaming Kafka extractor implementations. In addition to code reuse, the
> refactoring allows for writing unit tests for statistics tracker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
