[
https://issues.apache.org/jira/browse/GOBBLIN-984?focusedWorklogId=350084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350084
]
ASF GitHub Bot logged work on GOBBLIN-984:
------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/19 22:16
Start Date: 26/Nov/19 22:16
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2830: [GOBBLIN-984] Add
log4j2.xml to enable log4j2 functionality
URL:
https://github.com/apache/incubator-gobblin/pull/2830#issuecomment-558841034
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=h1)
Report
> Merging
[#2830](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/1da1e4040f95c9acba497ee208bf8c996cc8c9e8?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2830 +/- ##
============================================
+ Coverage 45.62% 45.63% +<.01%
- Complexity 8971 8976 +5
============================================
Files 1902 1902
Lines 71284 71284
Branches 7862 7862
============================================
+ Hits 32523 32529 +6
+ Misses 35771 35764 -7
- Partials 2990 2991 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.88% <0%> (-1.39%)` | `29% <0%> (-1%)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.87% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: |
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `15.68% <0%> (+0.84%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `35.51% <0%> (+2.8%)` | `12% <0%> (+1%)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0%> (+7.14%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2830/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=footer).
Last update
[1da1e40...7a90589](https://codecov.io/gh/apache/incubator-gobblin/pull/2830?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 350084)
Time Spent: 0.5h (was: 20m)
> Get Gobblin log outputting to work
> ----------------------------------
>
> Key: GOBBLIN-984
> URL: https://issues.apache.org/jira/browse/GOBBLIN-984
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [GOBBLIN-822]|[https://github.com/apache/incubator-gobblin/pull/2685]
> Introduced issues with the scripts not outputting logs. Need to include
> log4j2.xml in each service's `conf` folder
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
