[
https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=352961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352961
]
ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 20:30
Start Date: 03/Dec/19 20:30
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2788:
[GOBBLIN-939] Integrate usage of env variables in gobblin scripts and
standardize configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r353406054
##########
File path: gobblin-docs/user-guide/Gobblin-CLI.md
##########
@@ -35,23 +35,27 @@ options:
keystore Examine JCE Keystore files
watermarks Inspect streaming watermarks
job-store-schema-manager Database job history store schema
manager
-
- --conf-dir <gobblin-conf-dir-path> Gobblon config path. default is
'$GOBBLIN_HOME/conf/<exe-mode-name>'.
- --log4j-conf <path-of-log4j-file> default is
'<gobblin-conf-dir-path>/<execution-mode>/log4j.properties'.
- --jvmopts <jvm or gc options> String containing JVM flags to include,
in addition to "-Xmx1g -Xms512m".
- --jars <csv list of extra jars> Column-separated list of extra jars to
put on the CLASSPATH.
- --enable-gc-logs enables gc logs & dumps.
- --show-classpath prints gobblin runtime classpath.
- --help Display this help.
- --verbose Display full command used to start the
process.
- Gobblin Version: 0.15.0
+ gobblin-classpath shows the constructed gobblin
classpath
+
+ --conf-dir <gobblin-conf-dir-path> Gobblon config path. default is
'$GOBBLIN_HOME/conf/cli'.
+ --log4j-conf <path-of-log4j-file> default is
'<gobblin-conf-dir-path>/cli/log4j.properties'.
+ --work-dir <gobblin-work-dir> Gobblin work dir. default is
/Users/jsenjaliya/tools/gobblin-dist/gobblin-cluster-data.
+ --job-conf-dir <path-of-log4j-file> Job configuration dir to pick up the
jobs to run. default is /Users/jsenjaliya/tools/gobblin-dist/gobblin-jobs.
+ --jvmopts <jvm or gc options> JVM or GC parameters for the java
process to append to the default params: "-Xmx1g -Xms512m".
+ --jars <csv list of extra jars> Column-separated list of extra jars
to put on the CLASSPATH.
+ --enable-gc-logs enables gc logs & dumps.
+ --show-classpath prints gobblin runtime classpath.
+ --help Display this help.
+ --verbose Display full command used to start
the process.
```
Argument details:
-* `--conf-dir`: specifies the path to directory containing gobblin system
configuration files, like `application.conf` or `reference.conf`,
`log4j.properties` and `quartz.properties`.
+* `--conf-dir`: specifies the path to directory containing gobblin system
configuration files, like `application.conf` or `reference.conf`,
`log4j.properties` and `quartz.properties`, as this is provided as classpath
for config file look up.
Review comment:
meant `--conf-dir` value is supplied as classpath for any config file to be
looked up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 352961)
Time Spent: 3.5h (was: 3h 20m)
> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
> Key: GOBBLIN-939
> URL: https://issues.apache.org/jira/browse/GOBBLIN-939
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> 1. standardize config with ENV variables
> 2. define default env variables in gobblin-env.sh
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
