htran1 commented on a change in pull request #2722: GOBBLIN-865: Add feature
that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r353906224
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
##########
@@ -704,36 +708,114 @@ public boolean bulkApiLogin() throws Exception {
return success;
}
+ public JobIdAndBatchIdResultIdList
getQueryResultIdsPkChunkingFetchOnly(String jobId, String batchIdListStr) {
Review comment:
Please add javadoc for this public method. If this is only for testing then
mention that in the javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
