sv2000 commented on a change in pull request #2839: [GOBBLIN-993] Support job level hive configuration override URL: https://github.com/apache/incubator-gobblin/pull/2839#discussion_r354065480
########## File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveMetastoreClientPool.java ########## @@ -66,6 +69,10 @@ public static final String POOL_MIN_EVICTABLE_IDLE_TIME_MILLIS = "pool.min.evictable.idle.time.millis"; + public static final String POOL_HIVE_EXTRA_CONFIG_PREFIX = "hive.extraConfig."; Review comment: hive.extraConfig sounds awkward. Can we rename to hive.additionalProps or hive.additionalConfig? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
