[
https://issues.apache.org/jira/browse/GOBBLIN-1002?focusedWorklogId=357510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357510
]
ASF GitHub Bot logged work on GOBBLIN-1002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/19 23:25
Start Date: 10/Dec/19 23:25
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2847: GOBBLIN-1002: Set
state id when deserializing state from Gobblin stat…
URL:
https://github.com/apache/incubator-gobblin/pull/2847#issuecomment-564304442
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=h1)
Report
> Merging
[#2847](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/0469447f0732bf61a39d38af45e8c84715f87853?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `28.57%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2847 +/- ##
============================================
+ Coverage 45.62% 45.62% +<.01%
Complexity 8988 8988
============================================
Files 1904 1904
Lines 71349 71355 +6
Branches 7876 7876
============================================
+ Hits 32551 32554 +3
- Misses 35795 35799 +4
+ Partials 3003 3002 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh)
| `8.19% <0%> (-0.07%)` | `2 <0> (ø)` | |
|
[.../gobblin/runtime/CheckpointableWatermarkState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQ2hlY2twb2ludGFibGVXYXRlcm1hcmtTdGF0ZS5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...ava/org/apache/gobblin/metastore/ZkStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1prU3RhdGVTdG9yZS5qYXZh)
| `63.06% <100%> (+0.33%)` | `23 <0> (ø)` | :arrow_down: |
|
[...ava/org/apache/gobblin/metastore/FsStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZzU3RhdGVTdG9yZS5qYXZh)
| `36.05% <50%> (+0.19%)` | `14 <0> (ø)` | :arrow_down: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `65.27% <0%> (+0.46%)` | `28% <0%> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=footer).
Last update
[0469447...595c7a8](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 357510)
Time Spent: 40m (was: 0.5h)
> Set state id when deserializing state from Gobblin state store
> --------------------------------------------------------------
>
> Key: GOBBLIN-1002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1002
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Current behavior returns the deserialized state without setting the state id
> member field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
