sv2000 commented on a change in pull request #2899: [GOBBLIN-1060]Fix wrong
fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899#discussion_r384128391
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##########
@@ -608,21 +608,22 @@ private Resource
prepareContainerResource(GetNewApplicationResponse newApplicati
Path appMasterWorkDir = new Path(appWorkDir,
GobblinYarnConfigurationKeys.APP_MASTER_WORK_DIR_NAME);
Map<String, LocalResource> appMasterResources = Maps.newHashMap();
+ FileSystem localFs = FileSystem.getLocal(this.yarnConfiguration);
Review comment:
Maybe it is safer to use FileSystem.getLocal(new Configuration()) since we
are dependent of fs.defaultFS not being configured in yarnConfiguration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
