arjun4084346 commented on issue #2890: [GOBBLIN-1050] Verify requester when 
updating/deleting FlowConfig
URL: 
https://github.com/apache/incubator-gobblin/pull/2890#issuecomment-591191796
 
 
   I did not like the idea of updating signature of update at multiple places. 
It made the code non-uniform. Place of requesterList as a parameter in update() 
is not quite justified in my opinion.
   Is it possible to do checkRequester() in FlowConfigsResource::update/delete 
instead of doing in resource handlers' update/delete ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to