[
https://issues.apache.org/jira/browse/GOBBLIN-1040?focusedWorklogId=395718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395718
]
ASF GitHub Bot logged work on GOBBLIN-1040:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/20 02:42
Start Date: 02/Mar/20 02:42
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r386164499
##########
File path:
gobblin-modules/gobblin-kafka-08/src/main/java/org/apache/gobblin/kafka/client/Kafka08ConsumerClient.java
##########
@@ -345,8 +350,8 @@ public GobblinKafkaConsumerClient create(Config config) {
private final MessageAndOffset messageAndOffset;
- public Kafka08ConsumerRecord(MessageAndOffset messageAndOffset) {
- super(messageAndOffset.offset(), messageAndOffset.message().size());
+ public Kafka08ConsumerRecord(MessageAndOffset messageAndOffset, int
partition, String topic) {
Review comment:
can we change the argument order to first have topic and then partition to
be consistent with other APIs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 395718)
Time Spent: 40m (was: 0.5h)
> Fix High level consumer
> ------------------------
>
> Key: GOBBLIN-1040
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1040
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
