sv2000 commented on a change in pull request #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r386174010
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/kafka/HighLevelConsumerTest.java
##########
@@ -51,32 +101,69 @@ private static String getConfigKey(Optional<String>
prefix, String key) {
}
@Test
- public void test() throws Exception {
+ public void testConsumerAutoOffsetCommit() throws Exception {
+ Properties consumerProps = new Properties();
+ consumerProps.setProperty(ConfigurationKeys.KAFKA_BROKERS, _kafkaBrokers);
+
consumerProps.setProperty(Kafka09ConsumerClient.GOBBLIN_CONFIG_VALUE_DESERIALIZER_CLASS_KEY,
"org.apache.kafka.common.serialization.ByteArrayDeserializer");
+ consumerProps.setProperty("source.kafka.consumerConfig.auto.offset.reset",
"earliest");
- MockKafkaStream mockKafkaStream = new MockKafkaStream(5);
- MockedHighLevelConsumer consumer = new
MockedHighLevelConsumer(getSimpleConfig(Optional.<String>absent()), 5,
mockKafkaStream);
+ MockedHighLevelConsumer consumer = new MockedHighLevelConsumer(TOPIC,
ConfigUtils.propertiesToConfig(consumerProps), NUM_PARTITIONS);
+ consumer.startAsync().awaitRunning();
- consumer.startAsync();
- consumer.awaitRunning();
-
- Assert.assertTrue(consumer.getMessages().isEmpty());
+ consumer.awaitExactlyNMessages(NUM_MSGS, 5000);
+ consumer.shutDown();
+ }
- mockKafkaStream.pushToStream("message");
+ @Test
+ public void testConsumerManualOffsetCommit() throws Exception {
+ Properties consumerProps = new Properties();
+ consumerProps.setProperty(ConfigurationKeys.KAFKA_BROKERS, _kafkaBrokers);
+
consumerProps.setProperty(Kafka09ConsumerClient.GOBBLIN_CONFIG_VALUE_DESERIALIZER_CLASS_KEY,
"org.apache.kafka.common.serialization.ByteArrayDeserializer");
+ consumerProps.setProperty("source.kafka.consumerConfig.auto.offset.reset",
"earliest");
+ consumerProps.put("enable.auto.commit", false);
Review comment:
HighLevelConsumer.ENABLE_AUTO_COMMIT instead of enable.auto.commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
