[
https://issues.apache.org/jira/browse/GOBBLIN-1069?focusedWorklogId=397837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397837
]
ASF GitHub Bot logged work on GOBBLIN-1069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 20:02
Start Date: 04/Mar/20 20:02
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2908:
[GOBBLIN-1069] Add NPE check in handleContainerCompletion method
URL: https://github.com/apache/incubator-gobblin/pull/2908#discussion_r387903741
##########
File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java
##########
@@ -620,7 +620,10 @@ private boolean shouldStickToTheSameNode(int
containerExitStatus) {
*/
protected void handleContainerCompletion(ContainerStatus containerStatus) {
Map.Entry<Container, String> completedContainerEntry =
this.containerMap.remove(containerStatus.getContainerId());
-
+ if (completedContainerEntry == null) {
Review comment:
In what kind of scenarios will it happen, when you say " we don't maintain
this container " ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397837)
Time Spent: 20m (was: 10m)
> Add NPE check in handleContainerCompletion method
> -------------------------------------------------
>
> Key: GOBBLIN-1069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add NPE check in handleContainerCompletion method to make sure call the
> method twice for the same container will not fail the job
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
