sv2000 commented on a change in pull request #2907: [GOBBLIN-1068]Clean up
cyclic logic in task cancellation
URL: https://github.com/apache/incubator-gobblin/pull/2907#discussion_r387988894
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -160,25 +163,40 @@ public void run()
}
} catch (InterruptedException interrupt) {
log.info("Job interrupted by InterrupedException.");
- interruptTaskExecution(countDownLatch);
+ interruptTaskExecution(Optional.of(countDownLatch));
}
log.info("All assigned tasks of job {} have completed in container {}",
jobId, containerIdOptional.or(""));
}
- private void interruptTaskExecution(CountDownLatch countDownLatch)
- throws InterruptedException {
+ /**
+ * A helper function that shutting down all outstanding tasks and destroy
taskExecutor if timeout on waiting for
Review comment:
Change to "...that shuts down all outstanding tasks and shuts down the
taskExecutor if it times out on a task termination"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
