[
https://issues.apache.org/jira/browse/GOBBLIN-1116?focusedWorklogId=422258&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422258
]
ASF GitHub Bot logged work on GOBBLIN-1116:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/20 19:30
Start Date: 14/Apr/20 19:30
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2956: GOBBLIN-1116:
Avoid registering schema with schema registry during Me…
URL:
https://github.com/apache/incubator-gobblin/pull/2956#issuecomment-613638407
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=h1)
Report
> Merging
[#2956](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/b64cb3b3442e07b2906dfabe75376e3382fc9457&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `44.58%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2956 +/- ##
============================================
+ Coverage 45.55% 45.58% +0.03%
- Complexity 9160 9183 +23
============================================
Files 1937 1939 +2
Lines 73364 73511 +147
Branches 8100 8122 +22
============================================
+ Hits 33420 33513 +93
- Misses 36847 36888 +41
- Partials 3097 3110 +13
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...he/gobblin/converter/csv/CsvToJsonConverterV2.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9jc3YvQ3N2VG9Kc29uQ29udmVydGVyVjIuamF2YQ==)
| `75.40% <ø> (+2.39%)` | `12.00 <0.00> (ø)` | |
|
[...ache/gobblin/metrics/reporter/util/EventUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci91dGlsL0V2ZW50VXRpbHMuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...bblin/metrics/reporter/util/MetricReportUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci91dGlsL01ldHJpY1JlcG9ydFV0aWxzLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=)
| `0.00% <ø> (-30.56%)` | `0.00 <0.00> (-2.00)` | |
|
[...che/gobblin/converter/EnvelopeSchemaConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbnZlbG9wZVNjaGVtYUNvbnZlcnRlci5qYXZh)
| `41.46% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
|
[.../apache/gobblin/metrics/KafkaReportingFormats.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvS2Fma2FSZXBvcnRpbmdGb3JtYXRzLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...gobblin/metrics/kafka/KafkaAvroSchemaRegistry.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FBdnJvU2NoZW1hUmVnaXN0cnkuamF2YQ==)
| `13.67% <0.00%> (-1.14%)` | `2.00 <0.00> (ø)` | |
|
[...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ache/gobblin/metrics/kafka/KafkaReporterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlclV0aWxzLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [22
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2956/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=footer).
Last update
[b64cb3b...4aacea8](https://codecov.io/gh/apache/incubator-gobblin/pull/2956?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 422258)
Time Spent: 20m (was: 10m)
> Avoid registering schema with schema registry during MetricReporting
> initialization from cluster workers
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1116
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1116
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This PR avoids having to register schema with schema registry on Kafka metric
> reporter initialization from cluster workers. This avoids a potentially large
> number of connections that may be initiated with Kafka Schema registry on
> Gobblin on Yarn application launch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
