[
https://issues.apache.org/jira/browse/GOBBLIN-1150?focusedWorklogId=434127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434127
]
ASF GitHub Bot logged work on GOBBLIN-1150:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/20 01:35
Start Date: 17/May/20 01:35
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#2988:
URL: https://github.com/apache/incubator-gobblin/pull/2988#discussion_r426206969
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlSpecStore.java
##########
@@ -65,31 +65,49 @@
private static final String CREATE_TABLE_STATEMENT =
"CREATE TABLE IF NOT EXISTS %s (spec_uri VARCHAR(128) NOT NULL, tag
VARCHAR(128) NOT NULL, spec LONGBLOB, PRIMARY KEY (spec_uri))";
+ private static final String CREATE_TABLE_STATEMENT_V2 =
+ "CREATE TABLE IF NOT EXISTS %s (spec_uri VARCHAR(128) NOT NULL,
flow_group VARCHAR(128), flow_name VARCHAR(128), "
Review comment:
will 'owningGroup' be a string, or a json having some more information
like a requester list? if we are not sure, we can leave this column for
implementation time, otherwise we might have to add additional column for
'owningGroup' if we choose a wrong type now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434127)
Time Spent: 0.5h (was: 20m)
> change spec store table to use json type
> ----------------------------------------
>
> Key: GOBBLIN-1150
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1150
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
