jack-moseley commented on a change in pull request #2993:
URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r428920315



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -259,6 +259,7 @@ public void orchestrate(Spec spec) throws Exception {
         // In this case, the current time is used as the flow executionId.
         
flowMetadata.putIfAbsent(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
             Long.toString(System.currentTimeMillis()));
+        flowMetadata.put(TimingEvent.METADATA_MESSAGE, "Flow compilation 
failed");

Review comment:
       We could, the reason I didn't want to is it would be kind of misleading 
right now since sometimes that will have unrelated missing config messages. I 
guess for now I could just add it and say "it may be due to these errors".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to