[
https://issues.apache.org/jira/browse/GOBBLIN-1154?focusedWorklogId=437582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437582
]
ASF GitHub Bot logged work on GOBBLIN-1154:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 04:10
Start Date: 27/May/20 04:10
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#2993:
URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r430694079
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java
##########
@@ -81,7 +83,7 @@ public CreateKVResponse createFlowConfig(FlowConfig
flowConfig, boolean triggerL
} else if
(Boolean.parseBoolean(responseMap.getOrDefault(ServiceConfigKeys.COMPILATION_SUCCESSFUL,
new AddSpecResponse<>("false")).getValue().toString())) {
httpStatus = HttpStatus.S_201_CREATED;
} else {
- httpStatus = HttpStatus.S_400_BAD_REQUEST;
+ throw new RestLiServiceException(HttpStatus.S_400_BAD_REQUEST, "Flow was
not compiled successfully");
Review comment:
The reason could be a couple things:
1. No path found. This could be due to: the edges don't have the paths they
are using, there are no edges between those nodes, the nodes or edges were not
added on gaas startup due to an error, etc.
2. There is an unresolved config. We do have a field that stores whatever
errors we encountered with unresolved config.
The problems are:
- If it fails due to 1, there isn't really any way to know exactly what went
wrong since we don't know what the intended path was.
- Even if it fails due to 1, we may have encountered some unresolved config
on a separate unintended path. So it would be pretty confusing to include an
error that some config was unresolved when the real reason was that the path.
If anything maybe the best message for now would just be "This could be
because no path is found, or because of X unresolved config"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 437582)
Time Spent: 2h 20m (was: 2h 10m)
> Improve gaas error messages
> ---------------------------
>
> Key: GOBBLIN-1154
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1154
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
