autumnust commented on a change in pull request #3012:
URL: https://github.com/apache/incubator-gobblin/pull/3012#discussion_r432780498



##########
File path: gobblin-modules/gobblin-orc-dep/build.gradle
##########
@@ -62,4 +65,21 @@ shadowJar {
   relocate 'com.google', 'shadow.gobblin.orc.com.google'
 }
 
+// assigning a differnet classifer to the main jar
+// so that it does not override the shadow jar

Review comment:
       Thanks for comment ! 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to