arjun4084346 commented on a change in pull request #3001:
URL: https://github.com/apache/incubator-gobblin/pull/3001#discussion_r432878416
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java
##########
@@ -358,4 +361,50 @@ public URI getUri() {
public Boolean isExplain() {
return ConfigUtils.getBoolean(getConfig(),
ConfigurationKeys.FLOW_EXPLAIN_KEY, false);
}
+
+ @Slf4j
+ public static class Utils {
Review comment:
a separate util class is preferred over util methods, to keep util
methods cleanly separate.
a nested util class instead of an outer class is just a coding style
preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
