[
https://issues.apache.org/jira/browse/GOBBLIN-1212?focusedWorklogId=459569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459569
]
ASF GitHub Bot logged work on GOBBLIN-1212:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/20 23:14
Start Date: 15/Jul/20 23:14
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3060:
URL: https://github.com/apache/incubator-gobblin/pull/3060#discussion_r455417617
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcUtils.java
##########
@@ -491,18 +491,34 @@ public static WritableComparable
createValueRecursively(TypeDescription schema)
*/
public static boolean eligibleForUpConvertHelper(TypeDescription
originalSchema, TypeDescription targetSchema) {
if (!targetSchema.getCategory().isPrimitive()) {
- if
(!originalSchema.getFieldNames().containsAll(targetSchema.getFieldNames())) {
- return false;
- }
- boolean result = true;
+ if (targetSchema.getCategory().equals(TypeDescription.Category.LIST)) {
+ return eligibleForUpConvertHelper(originalSchema.getChildren().get(0),
targetSchema.getChildren().get(0));
Review comment:
Will add a safety-guard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459569)
Time Spent: 0.5h (was: 20m)
> Handle shuffle-key eligibility check properly
> ----------------------------------------------
>
> Key: GOBBLIN-1212
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1212
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
