autumnust commented on a change in pull request #3064:
URL: https://github.com/apache/incubator-gobblin/pull/3064#discussion_r457749028



##########
File path: 
gobblin-data-management/src/test/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblinDistcpTest.java
##########
@@ -83,6 +118,87 @@ public void test() throws Exception {
     Assert.assertTrue(new File(tmpTarget, fileName).exists());
   }
 
+  @Test
+  public void hiveTest() throws Exception {
+    // Hive Environment set-up
+    HiveConf hiveConf = new HiveConf();
+
+    try {
+      // Start a Hive session in this thread and register the UDF
+      SessionState.start(hiveConf);
+      SessionState.get().initTxnMgr(hiveConf);
+    } catch (HiveException he) {
+      throw new RuntimeException("Failed to start Hive session.", he);
+    }
+    try {
+      jdbcConnector = HiveJdbcConnector.newEmbeddedConnector(2);
+    } catch (SQLException se) {
+      throw new RuntimeException("Cannot initialize the jdbc-connector due to: 
", se);
+    }

Review comment:
       Thanks for catching, this is the duplicated code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to