[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #3065: [GOBBLIN-1217] start metrics reporting with a few map-reduce properties

[GitBox]

arjun4084346 commented on a change in pull request #3065:
URL: https://github.com/apache/incubator-gobblin/pull/3065#discussion_r458302607



##########
File path: 
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
##########
@@ -367,6 +374,20 @@ public void startMetricReportingWithFileSuffix(State 
state, String metricsFileSu
       oldMetricsFileSuffix += "." + metricsFileSuffix;
     }
     metricsReportingProps.setProperty(ConfigurationKeys.METRICS_FILE_SUFFIX, 
oldMetricsFileSuffix);
+
+    if (!Strings.isNullOrEmpty(metricsFileSuffix)) {
+      String[] tokens = metricsFileSuffix.split("_");

Review comment:
       I could not find any API which gives task number and attempt. 
getTaskAttemptID().getJobID(), getTaskAttemptID().getTaskID(), 
getTaskAttemptID().getId() did not quite give what I am trying to extract from 
taskAttemptID.
   I'll use context.getTaskAttemptID().getTaskType()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org