[
https://issues.apache.org/jira/browse/GOBBLIN-1220?focusedWorklogId=462302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462302
]
ASF GitHub Bot logged work on GOBBLIN-1220:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/20 00:08
Start Date: 23/Jul/20 00:08
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#2991:
URL: https://github.com/apache/incubator-gobblin/pull/2991#discussion_r459148432
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java
##########
@@ -122,8 +122,7 @@ public static void submitJobToQueue(
static void waitJobInitialization(
HelixManager helixManager,
String workFlowName,
- String jobName,
- long timeoutMillis) throws Exception {
Review comment:
It was being called only from two places, with fix value in both the
places , one is "300_000" (which has a typo), other is Long.MAX_VALUE, which
doesn't make sense. I think we should not try that much for a helix job to
initialize. I have fixed it to 5 minutes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 462302)
Time Spent: 40m (was: 0.5h)
> reduce helix job initialization timeout from long.maxval to 5 minutes
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1220
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1220
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
