[
https://issues.apache.org/jira/browse/GOBBLIN-1221?focusedWorklogId=464632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-464632
]
ASF GitHub Bot logged work on GOBBLIN-1221:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/20 16:24
Start Date: 30/Jul/20 16:24
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3069:
URL: https://github.com/apache/incubator-gobblin/pull/3069#discussion_r463118971
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java
##########
@@ -185,9 +185,39 @@ public void handleUnpublishedWorkUnits(Collection<?
extends WorkUnitState> state
return datasetRoots;
}
+ /**
+ * Unlike other preserving attributes of files (ownership, group, etc.),
which is preserved in writer,
+ * some of the attributes have to be set during publish phase like ModTime,
+ * and versionStrategy (usually relevant to modTime as well), since they are
subject to change with Publish(rename)
+ */
+ private void preserveFileAttrInPublisher(CopyableFile copyableFile) throws
IOException {
+ // Preserving File ModTime, keep the accessing time of the target file.
+ if
(copyableFile.getPreserve().preserve(PreserveAttributes.Option.MOD_TIME)) {
+ fs.setTimes(copyableFile.getDestination(),
copyableFile.getOriginTimestamp(),
+ fs.getFileStatus(copyableFile.getDestination()).getAccessTime());
Review comment:
Actually I think a bit more into the accessTime, it might makes more
sense to set this to -1 since the preservation of ModTime is actually breaking
the semantics already (we preserve it for special use cases only) and it
doesn't make sense to keep the original access time either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 464632)
Time Spent: 0.5h (was: 20m)
> Preserve ModTime by configuration in distcpNg
> ---------------------------------------------
>
> Key: GOBBLIN-1221
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1221
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
