[
https://issues.apache.org/jira/browse/GORA-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450489#comment-13450489
]
Ferdy Galema commented on GORA-103:
-----------------------------------
Hi,
I took a first glance at the patch and please see remarks/questions below. I
have not yet tested the actual store (I am sure it works as advertised), but
mostly looked at changes to existing classes first.
log4j.properties default level is set to DEBUG. Is this intentional?
I am curious why Persistent is changed to PersistentBase in a lot of classes.
I noticed that many times tabs are used for indentation. When you try to apply
patch in Eclipse you see them very clearly. Should all be spaces.
Also I see that a lot of @Override annotations are removed or commented out. If
@Override annotations give you compile errors in your IDE you should disable
these. It think it is accepted nowadays that @Override can be used for both
implementation overrides (X extends Y) and interface implementations (X
implements Y).
Finally I think the Exception exception is overused. I understand that
Exception can be thrown in implementations, but to change the interface from
IOException to Exception in a lot of places is not the best solution, imho.
That causes all method callers to need to catch Exception or also allow to
throw Exception. It is better to simply wrap Exception in IOException as soon
as possible in implementations, so you do not need to change interfaces that
much.
> Datastore for gora-dynamodb
> ----------------------------
>
> Key: GORA-103
> URL: https://issues.apache.org/jira/browse/GORA-103
> Project: Apache Gora
> Issue Type: New Feature
> Components: storage-dynamodb
> Affects Versions: 0.3
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Labels: gsoc, gsoc2012
> Fix For: 0.3
>
> Attachments: GORA-103-final.patch, GORA-103.patch, GORA-103.v2.patch,
> GORA-103-v3.patch, GORA-103-v4.patch
>
>
> As per comments on the Gora dev@ mailing list, and per our application
> submission [1] and ideas page [2], this issue should track, from start to
> finish the development, montoring, reviwing, testing and eventual
> implementation of the gora-dynamodb module for Gora.
> [1] https://cwiki.apache.org/confluence/display/GORA/GSoC+2012
> [2] https://cwiki.apache.org/confluence/display/GORA/GSoC+2012+Ideas+Page
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
