[ 
https://issues.apache.org/jira/browse/GORA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500575#comment-13500575
 ] 

Alfonso Nishikawa commented on GORA-174:
----------------------------------------

@Julien: after analyzing your test classes patch, I think they work as 
expected: before your changes, the class WebPage exists, and method 
WebPage#setContent() too. After your patch, without regenerating the class 
WebPage, the method WebPage#setContent() too, so WebPage#setContent(null) will 
not fail. DataFileAvroStore success writing a null. No problem.

To make it fail must: modify webpage.json, regenerate WebPage, and will not 
compile because the method WebPage#setContent() will not exist.
                
> GORA compiler does not handle ["string", "null"] unions in the AVRO schema
> --------------------------------------------------------------------------
>
>                 Key: GORA-174
>                 URL: https://issues.apache.org/jira/browse/GORA-174
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: schema
>    Affects Versions: 0.2.1
>            Reporter: Julien Nioche
>            Assignee: Alfonso Nishikawa
>             Fix For: 0.3
>
>         Attachments: GORA-174.patch, GORA-174-test.patch, 
> patch-tests_applied.out.tgz
>
>
> See NUTCH-1477 for description. 
> We are getting NPE when using the DataFileAvroStore, in order to avoid that I 
> modified the schema to allow for null values on some fields e.g.    {"name": 
> "baseUrl", "type": ["string", "null"] }
> however when generating the code for the schema the accessors are not 
> generated by GORA which prevents Nutch from compiling 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to