[ https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751550#comment-13751550 ]
Keith Turner commented on GORA-66: ---------------------------------- To expand on my previous comment about adding complexity to user code. With the gora.datastore.endkey property it seems like user may have to write code like the following. if(deleting) if(gora.datastore.endkey){ query.setEndKey(...); else query.setEndKey(...); else query.setEndKey(...); > testDeleteByQueryFields seems incorrect > --------------------------------------- > > Key: GORA-66 > URL: https://issues.apache.org/jira/browse/GORA-66 > Project: Apache Gora > Issue Type: Bug > Affects Versions: 0.2 > Reporter: Keith Turner > Fix For: 0.4 > > Attachments: GORA-66-1.patch > > > While writing the Accumulo backend I have been trying to run some of the > existing test against it. It seems that the test > DataStoreTestUtil.testDeleteByQueryFields() has two problems. > * The test does not flush the store after calling deleteByQuery(). This is > needed for accumulo since deletes are just inserts and must be flushed. > * The test expects the last key in a range that was deleted to be present. > As far as I can tell the end key in a query should be inclusive, but the test > treats as exclusive. > I will submit a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira