[ 
https://issues.apache.org/jira/browse/GORA-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832202#comment-13832202
 ] 

Enis Soztutar commented on GORA-119:
------------------------------------

Thanks for working on this. 
bq. we should keep filter in query after convert successfully at least for 
debugging or maybe submit query again.
If the filter is 1-to-1 transferrable, we do not want to filter twice, once on 
the client side, and once on the server side. 
the problem with Query.isLocalFilterEnabled() is that, the logic that the 
filter is not needed is kept outside of the filter. This means that it is not 
straightforward to decompose a filter into multiple parts, and execute some of 
the logic in server and some in client. The query has an all-or-nothing 
approach for replacing the filter. For example, if you want to have a 
FilterList or two filters, one is convertible to server-side filter, one is 
not, the data store should decompose this into pieces. If we want to keep 
whatever filter converted to server side, we can have a wrapper filter which 
passes everything, and replace the filter with this filter. 

bq. And GoraFilter to not confuse with Filter in HBase
We do not need to differentiate by classname. We have different package names 
already. It is better to be consistent with the rest of the gora API. 

The new patch does not include HBaseFilterUtil changes. 

> implement a filter enabled scan in gora
> ---------------------------------------
>
>                 Key: GORA-119
>                 URL: https://issues.apache.org/jira/browse/GORA-119
>             Project: Apache Gora
>          Issue Type: Improvement
>    Affects Versions: 0.2
>         Environment: gora hbase gora-core gora-hbase
>            Reporter: raf shin
>              Labels: filter, gora-core, gora-hbase, scan
>             Fix For: 0.4
>
>         Attachments: GORA-119-v1.txt, gora-119-v1.1.patch, gora-119_v2.patch
>
>
> it'll be very of help to implement a filtered scan to reduce the time of scan 
> in gora-core and gora-hbase components.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to