[ 
https://issues.apache.org/jira/browse/GORA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alparslan Avcı updated GORA-246:
--------------------------------

    Attachment: GORA-246v5.patch

Hi all,

I have uploaded a patch for some issues stated below:
- For Map and Array types with nullable entries (Ex.: "type": {"type":"map", 
"values": "string"},"default":{}), removal of entries by using .put(null) or 
.add(null) was not working. The patch fixes this issue.
- For unions that contain nullable Map and Array types (Ex.: "type": ["null", 
{"type": "map", "values": ["null", "string"]}]), .put() or .add() methods and 
removal of the field by using .set[Fieldname](null) was not working. The patch 
also fixes this issue.
- For all Map and Array types, clear() method still does not working, however 
.set[Fieldname](null) method can be used instead for now, I think.
- There were no tests about all of these issues, I will upload a patch to 
GORA-94 branch for this. 

For all the implementations, I have based the comments in GORA-174 issue and 
[~alfonso.nishikawa]'s development notes. 

[~lewismc] and [~alfonso.nishikawa], would you please check and comment about 
the patch?

> Upgrade to Avro 1.7.X in gora-hbase
> -----------------------------------
>
>                 Key: GORA-246
>                 URL: https://issues.apache.org/jira/browse/GORA-246
>             Project: Apache Gora
>          Issue Type: Sub-task
>          Components: gora-core, gora-hbase
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>             Fix For: 0.4
>
>         Attachments: GORA-246.patch, GORA-246v2.patch, GORA-246v3.patch, 
> GORA-246v3.patch, GORA-246v4.patch, GORA-246v5.patch, 
> GORA_246.HBaseDriverTest.patch, GORA_246.HBaseDriverTest.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to