[
https://issues.apache.org/jira/browse/GORA-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003561#comment-14003561
]
Renato Javier Marroquín Mogrovejo commented on GORA-326:
--------------------------------------------------------
Hi [~alparslan.avci],
The patch looks good, but I have some comments on it. If we are trying to hide
the "__g__dirty" field from the user then I think we should also update the put
method and not allow the user to directly change this value. This would mean we
will have to add specific methods to access this field.
This is probably the same case for the get method.
{code}
public void put(int field$, java.lang.Object value) {
switch (field$) {
case 0: __g__dirty = (java.nio.ByteBuffer)(value); break;
{\code}
Wdyt?
> Removal of _g_dirty field from _ALL_FIELDS array and Field Enum in Persistent
> classes
> -------------------------------------------------------------------------------------
>
> Key: GORA-326
> URL: https://issues.apache.org/jira/browse/GORA-326
> Project: Apache Gora
> Issue Type: Bug
> Components: gora-core
> Affects Versions: 0.4
> Reporter: Alparslan Avcı
> Priority: Minor
> Labels: gora-core
> Fix For: 0.5
>
> Attachments: GORA-326.patch
>
>
> In auto-generated persistent classes, we create an array field called
> ALL_FIELDS as you know. But this array also contains _g_dirty field, which is
> not a stored field at all. Maybe we should remove _g_dirty field from the
> array, since the array is used for getting all fields in the stored table. We
> can also remove it from Field enum, so the users do not know about the
> _g_dirty field.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
