[
https://issues.apache.org/jira/browse/GORA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041146#comment-14041146
]
Renato Javier Marroquín Mogrovejo commented on GORA-347:
--------------------------------------------------------
Thanks for making this happen [~kminooie]! :)
1. Why changing DEFAULT_COLUMNS_TTL from String to int if in
org.apache.gora.cassandra.store.HectorUtils.createColumn we still take a
String? I think it can keep on being a String and just to maintain the coding
style of this let's keep the createColumn as a single return and that check can
be done outside the column creation method. Or we change the createColumn
signature method to receive an integer and do the check outside as well. I like
the first option as all of the other properties are also strings.
2. +1
3. +1 but we also need to add them to sample properties file in
conf/gora-mapping.xml. Something like:
<keyspace name="Employee" host="localhost" cluster="Gora Cassandra Test
Cluster" placement_strategy="org.apache.cassandra.locator.SimpleStrategy"
replication_factor="1">
<family name="p" gc_grace_seconds="5"/>
<family name="sc" type="super" />
</keyspace>
And also parse them in the mapping classes :) I will assign this to you Kaveh
as you have done all the work.
Thanks for your awesome contributions!
> Column attributes should be obtained using the column name and not the field
> name.
> ----------------------------------------------------------------------------------
>
> Key: GORA-347
> URL: https://issues.apache.org/jira/browse/GORA-347
> Project: Apache Gora
> Issue Type: Improvement
> Reporter: Renato Javier Marroquín Mogrovejo
> Attachments: GORA-347.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
