Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/gora/pull/23#discussion_r28435053
  
    --- Diff: 
gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java 
---
    @@ -718,12 +718,13 @@ else if (effectiveSchema.getType() == Type.MAP) {
         }
       }
     
    -  private int putMap(Mutation m, int count, Schema valueType, Object o, 
Pair<Text, Text> col) throws GoraException {
    +    private int putMap(Mutation m, int count, Schema valueType, Object o, 
Pair<Text, Text> col,
    --- End diff --
    
    With the update, the Pair for col only used to get the name, could we just 
use the fieldName instead for the Query?
    I.E remove the col input param in putMap and putArray.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to